[guide-analysis] Host guide browser in hail-vdc #14078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danking
reviewed
Dec 7, 2023
| preemptible: "false" | ||
| containers: | ||
| - name: guide-analysis | ||
| image: gneak123/guide_browser:amd@sha256:d3801eb2ff08ac0b5e9587ee3780dfa491bc087c367bc8bf3d252b2e60fae5b6 |
danking
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the k8s config necessary to host the guide browser in our k8s cluster. You can see it running in dev here. There's not much special here, a deployment with the browser app and an envoy sidecar to handle TLS. Once this merges and the
ssl-config-guide-analysisis created indefaultI canmake -C guide deploy NAMESPACE=defaultand then recreate the certs to pick up the new subdomain, after which it should be live.Resolves #14067